Versions Compared

Old Version 16

changes.mady.by.user Erik Ziegler

Saved on

compared with

New Version Current

changes.mady.by.user Erik Ziegler

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
  •  Erik Ziegler Merge current dev branches, then the rest of these PRs go into dev

...

IssueReasonPlan
imageCache :: memory leak (critical)Large DICOM files with sharedCacheKey will crash the browserMerge into dev branch
Fix #82: drawInvalidated() should pass trueRequired for requestAnimationFrame support
Display the images that have only VOI LUT Sequence properlyFixes bug with VOI LUT support
  •  Former user (Deleted) will review Evren Ozkan's PR and if it is unacceptable, he will close it. He has investigated this issue and has another fix which may be more appropriate.


Making the canvas, context and its rendering data specific to each enabledElementFixes race condition with renderingMerge immediately
WIP: Prototype of multi-layer compositionDevelopment PRLeave open
Make cornerstone Promise/A+ compliantNot sure we intend to make Cornerstone Promise compliant
  • Everywhere else can return promises
  • Fix documentation to specify imageLoaders should return Deferred
  • Why do we want to use Deferreds?:
    • So we can cancel the image loading
  • Start moving towards the removal of the jQuery dependency
    • Future: allow the dev to specify what type of Promises / Promise library Cornerstone should use
    • Create an example of how to use Cornerstone without jQuery for the Promises
Rendering loopUses requestAnimationFrame.
Add possibility to display image staticallyUseful for PreviewsReview / Merge
Rendering using css transform instead of canvas transformDevelopment PRLeave open (or close?)
Added canvasToPixel function for easier use in cornerstoneToolsHelper function which will help us clean up Cornerstone ToolsMerge immediately
WIP: WebGL renderingAdds optional WebGL rendering path. This is stable and has been used in OHIF for months.
  •  Erik Ziegler and Former user (Deleted) Look into non-linear LUT in WebGL branch. That may be the last issue remaining before it can be merged. Non-linear LUTs will be used in large images.
  •  Erik Ziegler Force developer to explicitly handle WebGL failure via an event or something like that
  •  Erik Ziegler Document the fact that WebGL branch is not the 'final solution' and will change and may be unstable. This is why it is opt-in.
  •  Does WebGL cause too much overhead when switching images?
  •  Look into changing Cornerstone's API to allow devs to plug in new rendering types to support pyramid type rendering or JF's rendering type

...

  • Viewers / Cornerstone should use requestAnimationFrame loop to display images
  • Multi-layer composition work is ongoing

...